why not make kdsingleapplication required in cmake?

jms

Just wondering why not make it a requirement in cmake if it will be built anyway
https://github.com/strawberrymusicplayer/strawberry/blob/05381096aa47b04117254f09d5954c0b2ab801ff/CMakeLists.txt#L312

jonas

@jms
Because many linux distributions do not have KDSingleApplication yet, and we also require version 1.1.0 which was released in December. But the plan in the long run is to drop it from 3rdparty altogether.

jms

@jonas
ok
Thanks for you're explanation and your work

rajm

@jonas I'm trying to build strawberry and getting a failure on finding KDSingleApplication-qt6Config.cmake so far I'm not finding the right package on Kubuntu 23.10 what dev package am I missing?

jonas

@rajm said in why not make kdsingleapplication required in cmake?:

KDSingleApplication

It's available in the upcoming Ubuntu Noble: https://packages.ubuntu.com/search?keywords=kdsingleapplication&searchon=names&suite=all&section=all (but too old anyway).

But CMake should not fail, it should fallback to using 3rdparty/kdsingleapplication.

rajm

@jonas I'm getting (after deleting CMakeCache.txt)

  By not providing "FindKDSingleApplication-qt6.cmake" in CMAKE_MODULE_PATH
  this project has asked CMake to find a package configuration file provided
  by "KDSingleApplication-qt6", but CMake did not find one.

  Could not find a package configuration file provided by
  "KDSingleApplication-qt6" (requested version 1.1.0) with any of the
  following names:

    KDSingleApplication-qt6Config.cmake
    kdsingleapplication-qt6-config.cmake

  Add the installation prefix of "KDSingleApplication-qt6" to
  CMAKE_PREFIX_PATH or set "KDSingleApplication-qt6_DIR" to a directory
  containing one of the above files.  If "KDSingleApplication-qt6" provides a
  separate development package or SDK, be sure it has been installed.

and then

CMake Error at 3rdparty/kdsingleapplication/CMakeLists.txt:5 (add_library):
  Cannot find source file:

    KDSingleApplication/src/kdsingleapplication.cpp

code_text

Using -DBUILD_WITH_QT6=ON

jonas

@rajm said in why not make kdsingleapplication required in cmake?:

3rdparty/kdsingleapplication

This suggests that 3rdparty/kdsingleapplication is missing. Is the sources from git? In that case you need to clone the repository with submodules using: git clone --recursive or use git submodule update --init --recursive if it is already cloned.

rajm

@jonas Ah submodules - thanks for the pointer! cmake now works.