Make Entire Spanner Icon Clickable
The Spanner icon that is displayed beside the search bar on the Collection menu does nothing if the icon itself is clicked, and only displays a menu if the blank space to the right of it is clicked. The menu that appears under it should show up if the spanner icon is clicked at all, and some kind of visual icon should appear beside the spanner icon to indicate that there are further options.
I believe it would be more intuitive if clicking the spanner icon brought up the Strawberry preferences window, and if the menu was only pressed with the gap to the right of the button is pressed. Also, in this case as well, the gap should have some visual indication that a menu will appear, such as a triangle facing down or a dot.
I would also like to mention that this feature would be welcomed by Plasma Wayland users such as myself. Currently, global menus do not work in the vast majority of applications, so this button is the only way for users to access the Strawberry settings. I was originally writing a bug report, because I thought the spanner button did not work. It wasn't until I accidentally happened to click on the blank part on the right that I realised I had to click there to summon the submenu.
The functionality that happens when the spanner icon is clicked can be discussed by developers, but I believe the entire button should be clickable and do some sort of action, even if it is just simply summoning the submenu.
jonas last edited by
I fixed so that the menu shows up when clicking the icon too: https://github.com/strawberrymusicplayer/strawberry/commit/1cc2e6303ae049bee418bbcaa99aefff5e8b476f
But there is supposed to be an arrow beside the icon, I see it works on Linux with the Fusion style, but does not work on Windows or macOS.
@jonas Thanks for the fix! However, the arrow does not show up on Linux with the Fusion style either. My screenshots were taken on Arch Linux with KDE Plasma, the arrow does not show up for me. I'm unsure about Windows or macOS, I'll take your word for that :smile_cat:
jonas last edited by
I was testing with the Qt development branch where it works. When testing with Qt 6.2.2 it does not work. It's a Qt bug present in Qt 6.2.2 that is already fixed, so it will resolve itself when the next Qt release is available.
A bunch of Qt updates came through Pacman last night, a few for Qt6 too, and it seems like the icon appears now, so this is resolved :smile: