• Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Groups
    • Register
    • Login

    Lyrics from Genius show up incomplete in the context window

    Scheduled Pinned Locked Moved
    Technical Help
    2
    9
    371
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • E
      edbanshee
      last edited by

      The software shows lyrics to the songs, but they show up incomplete. The main source I use is Genius, so i dont know if its related to it, but all songs seem to end a few paragraphs earlier

      jonasJ 1 Reply Last reply Reply Quote 0
      • jonasJ
        jonas @edbanshee
        last edited by

        @edbanshee
        I noticed that too, I'm working on fixing it.

        jonasJ 1 Reply Last reply Reply Quote 0
        • jonasJ
          jonas @jonas
          last edited by

          Can you test the latest from https://builds.strawberrymusicplayer.org/ and see if it works now

          E 1 Reply Last reply Reply Quote 1
          • E
            edbanshee @jonas
            last edited by edbanshee

            @jonas I tried the latest build, it improved but still not fixed completely, songs are still missing one or two paragraphs. However it is consistently showing more than before, missing only the few last parts of every song ive tested.

            Edit: Also, shorter songs (e.g I dont want to cry anymore by Magdalena Bay) show completely fine. Its an issue on the longer songs side only

            jonasJ 1 Reply Last reply Reply Quote 0
            • jonasJ
              jonas @edbanshee
              last edited by

              It would be easier if I knew what songs aren't working.

              jonasJ E 2 Replies Last reply Reply Quote 0
              • jonasJ
                jonas @jonas
                last edited by

                I found another problem. For long songs there are multiple div tags with lyrics.

                1 Reply Last reply Reply Quote 0
                • E
                  edbanshee @jonas
                  last edited by edbanshee

                  @jonas Ah sorry, I have so many so I couldn't write them all, but here's a few examples:

                  -Surrender the Night by My Chemical Romance
                  -Indian Summer by HOAX
                  -It's Never Over (Hey Orpheus) by Arcade Fire
                  -Barry Bonds by Kanye West
                  -Bass God by Last Dinosaurs
                  -A Break, A Pause by As Tall As Lions

                  All of these are missing a few of their last paragraphs

                  Could it be that its only showing the first tag?

                  jonasJ 1 Reply Last reply Reply Quote 0
                  • jonasJ
                    jonas @edbanshee
                    last edited by jonas

                    @edbanshee
                    I've tested every song you listed now, and with the last change I did, they all work.
                    I also fixed a missing newline just now, so if you test with the newest with today date in a couple hours from https://builds.strawberrymusicplayer.org/ it should hopefully all work.
                    However, there are still some missing newlines between paragraphs as they appear on the webpage, that's not easy to fix, since it's div tags. but all paragraphs should appear now.

                    E 1 Reply Last reply Reply Quote 1
                    • E
                      edbanshee @jonas
                      last edited by

                      @jonas Tested the last build, indeed all the paragraphs are showing now!
                      Thank you for your continued work!

                      1 Reply Last reply Reply Quote 1
                      • First post
                        Last post
                      Powered by NodeBB | Contributors