DirectSoundSink non-errors not ignored when the message isn't in English

mataha

A variation of a similar issue; this time, upon turning off an audio output in a more graceful way, Strawberry logs the following (along with an error pop-up):

04:06:38.177 ERROR GstEnginePipeline:901            ErrorMessageReceived ID: 14 Domain: 3726 Code: 6 Error: "IDirectSoundBuffer_GetStatus Operacja uko˝czona pomyťlnie.\r\n, IDirectSoundBuffer_GetCurrentPosition: Operacja uko˝czona pomyťlnie.\r\n, dwStatus: 0"
04:06:38.189 ERROR GstEnginePipeline:902            ErrorMessageReceived ID: 14 Domain: 3726 Code: 6 Debug: "../gst-plugins-good-1.18.3/sys/directsound/gstdirectsoundsink.c(702): gst_directsound_sink_write (): /GstPlayBin:playbin-65/GstPlaySink:playsink/GstBin:abin/GstBin:audiobin/GstAutoAudioSink:autoaudiosink-66/GstDirectSoundSink:autoaudiosink-66-actual-sink-directsound"
04:06:38.203 ERROR GstEngine:569                    GStreamer error: 3726 6 "IDirectSoundBuffer_GetStatus Operacja uko˝czona pomyťlnie.\r\n, IDirectSoundBuffer_GetCurrentPosition: Operacja uko˝czona pomyťlnie.\r\n, dwStatus: 0"

Surprisingly, a path to handle these non-errors does exist in the code - however, it won't work when that message isn't in English (here - minus string encoding - 'Operacja ukończona pomyślnie' is Polish for 'Operation completed successfully') and an error will be emitted anyway.

Strawberry version: 0.8.5-152-g69032db3-qt6 on Microsoft Windows [Version 10.0.18363.1379]

jonas

@mataha
The code is there to workaround a gstreamer bug.
However directsound is deprecated and will be removed sooner or later so it's not a priority to fix it.
It will be resolved when we switch to wasapi2.